[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

Arthur Eubanks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 28 16:00:26 PDT 2020


aeubanks updated this revision to Diff 267073.
aeubanks added a comment.

I foolishly submitted without running check-all, and it turns out this broke a test under check-clang.
Looks like https://reviews.llvm.org/D62888 added tests in sancov-new-pm.c to make sure that sancov + LTO work together, but they won't after this change since the (Thin)LTO pipeline doesn't run things under `registerOptimizerLastEPCallback()`. So I deleted those tests. Other sanitizers don't work under LTO right now (at least for non-O0) because of the same thing. Does this make sense?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80692/new/

https://reviews.llvm.org/D80692

Files:
  clang/lib/CodeGen/BackendUtil.cpp
  clang/test/CodeGen/sancov-new-pm.c
  llvm/include/llvm/Passes/PassBuilder.h
  llvm/lib/Passes/PassBuilder.cpp
  llvm/tools/opt/NewPMDriver.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80692.267073.patch
Type: text/x-patch
Size: 8721 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200528/e7ae9f47/attachment.bin>


More information about the cfe-commits mailing list