[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

Arthur Eubanks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 28 13:45:40 PDT 2020


aeubanks added a comment.

In D80692#2061219 <https://reviews.llvm.org/D80692#2061219>, @leonardchan wrote:

> Would be worthwhile to write a small test that asserts Sancov runs before the other sanitizers under the new PM?
>
> Aside from this, LGTM.


Asserting that sancov runs before other sanitizers seems like overspecification to me. Really all we want to know is that something like msan + sancov work together, and there are tests for that which we are fixing with this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80692/new/

https://reviews.llvm.org/D80692





More information about the cfe-commits mailing list