[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext
Yitzhak Mandelbaum via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 28 09:53:23 PDT 2020
ymandel added inline comments.
================
Comment at: include/clang/ASTMatchers/ASTMatchersInternal.h:286
+
+ virtual llvm::Optional<ast_type_traits::TraversalKind> TraversalKind() const {
+ return {};
----------------
aaron.ballman wrote:
> `traversalKind()`
Stephen -- What was the resolution on this comment? I came across this when writing my recent fixes and it stood out for going against the style guide and the surrounding style. Is this intentional or an oversight?
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61837/new/
https://reviews.llvm.org/D61837
More information about the cfe-commits
mailing list