[PATCH] D74387: [OpenMP][SYCL] Improve diagnosing of unsupported types usage
Johannes Doerfert via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu May 28 09:15:57 PDT 2020
jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.
> This change even doesn't break my local check-clang LIT tests run, but I'm not really sure that such change is in scope of this patch, because DiagnoseUseOfDecl contains a lot of other diagnostics as well.
Fair. Let's do the following. We go with this as it is a clear improvement and almost complete. If you could provide a follow up to call `DiagnoseUseOfDecl`, or maybe just to the part we actually need, for member initialization, we can ask Clang folks to take a look. I think there is a reasonable way forward.
LGTM. Thanks a lot for implementing this in a generic and sharable way!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74387/new/
https://reviews.llvm.org/D74387
More information about the cfe-commits
mailing list