[PATCH] D50078: clang-format: support aligned nested conditionals formatting

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 28 09:15:42 PDT 2020


MyDeveloperDay added a comment.



> @MyDeveloperDay , @Typz -- could you please take a look at these two issues and give your feedback? (E) looks pretty bad. I'm not familiar enough with this patch to judge how easy / hard would it be to mitigate these.

I agree 'E' is a regression from

  return temp[0] > temp[1] ? temp[0] > temp[2] ? 0 : 2
                           : temp[1] > temp[2] ? 1 : 2;

to

  return temp[0] > temp[1]   ? temp[0] > temp[2] ? 0 : 2
         : temp[1] > temp[2] ? 1
                             : 2;




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50078/new/

https://reviews.llvm.org/D50078





More information about the cfe-commits mailing list