[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128
    Nemanja Ivanovic via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Thu May 28 05:24:05 PDT 2020
    
    
  
nemanjai marked 3 inline comments as done.
nemanjai added inline comments.
================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3970
+      DestWidth = 128;
+      break;
     case 'T':
----------------
rjmccall wrote:
> rjmccall wrote:
> > Are there interactions with the other mode specifiers?  For example, should this be allowed with integer modes?  If so, I think this needs more tests.
> I shouldn't have said "if so" — *either way*, this needs more tests.
Very good point. Thank you. Added.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80374/new/
https://reviews.llvm.org/D80374
    
    
More information about the cfe-commits
mailing list