[PATCH] D78990: [analyzer] Allow bindings of the CompoundLiteralRegion

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 28 03:13:02 PDT 2020


NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Great, thanks!



================
Comment at: clang/unittests/StaticAnalyzer/StoreTest.cpp:66
 
-    Store StInit = StMgr.getInitialStore(SFC).getStore();
-    SVal Zero = SVB.makeZeroVal(ACtx.IntTy);
-    SVal One = SVB.makeIntVal(1, ACtx.IntTy);
-    SVal NarrowZero = SVB.makeZeroVal(ACtx.CharTy);
+    Store StInit = SManager.getInitialStore(SFC).getStore();
+    SVal Zero = Builder.makeZeroVal(ASTCtxt.IntTy);
----------------
The reason i usually specify `S` to `St` is i want to avoid confusion with `SourceManager`. It still causes confusion with [Program]`StateManager` but those two rarely appear in the same code because `ProgramStateManager` provides wrappers for most of the `StoreManager`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78990/new/

https://reviews.llvm.org/D78990





More information about the cfe-commits mailing list