[PATCH] D80704: Remove WrapperMatcherInterface

Dmitri Gribenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 28 03:13:01 PDT 2020


gribozavr created this revision.
Herald added subscribers: cfe-commits, arichardson.
Herald added a project: clang.
gribozavr2 added a reviewer: ymandel.

WrapperMatcherInterface is an abstraction over a member variable -- in
other words, not much of an abstraction at all. I think it makes code
harder to read more than in helps with deduplication. Not to even
mention the questionable usage of the ~Interface suffix for a type with
state.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D80704

Files:
  clang/include/clang/ASTMatchers/ASTMatchersInternal.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80704.266791.patch
Type: text/x-patch
Size: 11486 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200528/4a3ffe7c/attachment-0001.bin>


More information about the cfe-commits mailing list