[PATCH] D80023: [clang-tidy] Add abseil-string-find-str-contains checker.

Thu May 28 01:35:13 PDT 2020

njames93 added inline comments.

================
Comment at: clang-tools-extra/clang-tidy/abseil/StringFindStrContainsCheck.cpp:40-44
+  // FIXME(tdl-g): These options are being parsed redundantly with the
+  // constructor because TransformerClangTidyCheck forces us to provide MakeRule
+  // before "this" is fully constructed, but StoreOptions requires us to store
+  // the parsed options in "this".  We need to fix TransformerClangTidyCheck and
+  // then we can clean this up.
----------------
I've put in a patch to hopefully address this shortcoming D80697. Don't worry about this right now, but If that lands then it will make this a lot cleaner.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80023/new/

https://reviews.llvm.org/D80023