[PATCH] D79800: [Sema] Implement DR2233

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

A couple of minor requests.  Otherwise this looks good to me, although I really would like @rsmith to sign off on this approach, especially given his involvement with the DRs.



================
Comment at: clang/lib/Sema/SemaTemplateInstantiateDecl.cpp:1985
+    // pack is expanded the user must've provided arguments for all parameters
+    // before it.
+    FunctionDecl *TemplatedDecl = FunctionTemplate->getTemplatedDecl();
----------------
There should be a space in "in between", or just use "between".

I don't think the line about "if a parameter pack is expanded..." is true as written.  What you're trying to say is something like "It's okay to remove earlier default arguments because the expanded parameters are required to have matching arguments, which they only can if all the earlier parameters have arguments as well."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79800/new/

https://reviews.llvm.org/D79800