[PATCH] D80654: WIP: Make it possible to use the traverse() matcher in clang-query

[Stephen Kelly via Phabricator via cfe-commits]

steveire marked an inline comment as done.
steveire added inline comments.


================
Comment at: clang/include/clang/ASTMatchers/ASTMatchersInternal.h:383
+  static DynTypedMatcher
+  constructTraversalWrapper(const DynTypedMatcher &InnerMatcher,
+                            ast_type_traits::TraversalKind TK);
----------------
ymandel wrote:
> I need this for my fix to Transformer. In fact, this is the only thing I need, rather than an overload of `traverse` for `DynTypedMatcher`.  Do you want me to split this into its own patch and send to you? Or, vice versa?
> 
> Also, whay `const DynTypedMatcher &InnerMatcher`? Given that it is immediately copied, why not just `DynTypedMatcher InnerMatcher`, which at least allows the caller to move-construct the argument and avoid the copy?
Yes, if you could split what ever you need out and incorporate it into your work I think that would be useful. 

I can rebase the rest of this once your fix is in.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80654/new/

https://reviews.llvm.org/D80654