[PATCH] D79945: [Sema] Comparison of pointers to complete and incomplete types

[Benson Chu via Phabricator via cfe-commits]

pestctrl marked an inline comment as done.
pestctrl added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6447
+  InGroup<C99>;
+def warn_typecheck_compare_complete_incomplete_pointers : ExtWarn<
+  "ordered comparison of complete and incomplete pointers (%0 and %1)">,
----------------
efriedma wrote:
> warn_typecheck_compare_complete_incomplete_pointers should be a Warning, not an ExtWarn.  And should be DefaultIgnore.  And should indicate why we're warning.  And should be in the group C99Compat.
I'm confused by what you mean for "indicate why we're warning". Should I change the warning text?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79945/new/

https://reviews.llvm.org/D79945