[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

[Sjoerd Meijer via Phabricator via cfe-commits]

SjoerdMeijer added a comment.

No objections.
Some nits inlined, which you can ignore if you think they are not correct.



================
Comment at: clang/include/clang/Basic/arm_neon_incl.td:218
 // d: double
+// b: bfloat
 //
----------------
nit: perhaps bfloat16?


================
Comment at: clang/include/clang/Basic/arm_neon_incl.td:240
 // F: change to floating category.
+// B: change to BFloat
 // P: change to polynomial category.
----------------
nit: perhaps BFloat16?


================
Comment at: clang/test/Preprocessor/aarch64-target-features.c:378
+
+// ================== Check BFloat Extensions.
+// RUN: %clang -target aarch64-arm-none-eabi -march=armv8.6-a+bf16 -x c -E -dM %s -o - 2>&1 | FileCheck -check-prefix=CHECK-BFLOAT %s
----------------
nit: BFloat16


================
Comment at: clang/test/Preprocessor/arm-target-features.c:855
+
+// ================== Check BFloat Extensions.
+// RUN: %clang -target arm-arm-none-eabi -march=armv8.6-a+bf16 -x c -E -dM %s -o - 2>&1 | FileCheck -check-prefix=CHECK-BFLOAT %s
----------------
same


================
Comment at: clang/utils/TableGen/NeonEmitter.cpp:746
     Name = Name.drop_front(4);
+  } else if (Name.startswith("bfloat")) {
+    T.Kind = BFloat16;
----------------
same?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79708/new/

https://reviews.llvm.org/D79708