[PATCH] D80606: [libTooling][NFC] Demo bug introduced in D72534.

Yitzhak Mandelbaum via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 27 06:27:49 PDT 2020


ymandel added a comment.

In D80606#2057136 <https://reviews.llvm.org/D80606#2057136>, @steveire wrote:

> It might make sense for now (in order to unblock you) to make the `Transformer` library explicitly require the `AsIs` mode. I am not so familiar with the transformer library, but I think you can do that by adding `traverse(AsIs, ...)` in `Transformer::registerMatchers`.
>
> The real fix is probably in adjusting `transformer::detail::buildMatchers`. I can look into that in a few hours.


Thanks for the suggestion - I agree that changing `registerMatchers` would be a short term fix, but I think its better to just fix `buildMatchers` directly. I'm working on a patch now, so need to look into it (though thanks for the offer!)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80606/new/

https://reviews.llvm.org/D80606





More information about the cfe-commits mailing list