[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts
Eli Friedman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue May 26 15:17:42 PDT 2020
efriedma added inline comments.
================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:10331
+ auto Alignment = CGM.getNaturalPointeeTypeAlignment(
+ E->getArg(0)->IgnoreParenCasts()->getType());
Ops[0] = Builder.CreateBitCast(Ops[0], llvm::PointerType::getUnqual(VTy));
----------------
IgnoreParenCasts() here seems really dubious. You could easily end up with a type that's not even a pointer.
Can we just set the alignment to 1 and leave it at that? It's not like it really matters for NEON.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79721/new/
https://reviews.llvm.org/D79721
More information about the cfe-commits
mailing list