[PATCH] D80472: [clangd] Add access specifier information to hover contents

Daniel Martín via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 26 13:38:29 PDT 2020


danielmartin updated this revision to Diff 266322.
danielmartin marked 2 inline comments as done.
danielmartin added a comment.

Address feedback

Rename getAccess to getAccessSpelling.
Replace more parts of the codebase that were using their own version of getAccessSpelling.
Use StringRef's str() method instead of explicit std::string constructor.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80472/new/

https://reviews.llvm.org/D80472

Files:
  clang-tools-extra/clang-doc/HTMLGenerator.cpp
  clang-tools-extra/clang-doc/MDGenerator.cpp
  clang-tools-extra/clangd/Hover.cpp
  clang/include/clang/Basic/Specifiers.h
  clang/lib/AST/DeclPrinter.cpp
  clang/lib/AST/JSONNodeDumper.cpp
  clang/lib/AST/TextNodeDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80472.266322.patch
Type: text/x-patch
Size: 5355 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200526/c04ac6c1/attachment.bin>


More information about the cfe-commits mailing list