[PATCH] D80554: [DebugInfo] Use SplitTemplateClosers (foo<bar<baz> >) in DWARF too

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 26 12:33:01 PDT 2020


sammccall marked an inline comment as done.
sammccall added inline comments.


================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:242
+    // SplitTemplateClosers yields better interop with GCC and GDB (PR46052).
+    PP.SplitTemplateClosers = true;
   }
----------------
amccarth wrote:
> So, in other words, we'll always set `PP.SplitTemplateClosers` to true, now.
Yes. I thought it was clearest to write it separately in each branch, as it's basically a coincidence and I can give a separate comment.

Happy to fold it together if you think it's confusing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80554/new/

https://reviews.llvm.org/D80554





More information about the cfe-commits mailing list