[PATCH] D80374: [Clang] Enable KF and KC mode for [_Complex] __float128

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 26 12:32:59 PDT 2020


rjmccall added inline comments.


================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:3970
+      DestWidth = 128;
+      break;
     case 'T':
----------------
rjmccall wrote:
> Are there interactions with the other mode specifiers?  For example, should this be allowed with integer modes?  If so, I think this needs more tests.
I shouldn't have said "if so" — *either way*, this needs more tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80374/new/

https://reviews.llvm.org/D80374





More information about the cfe-commits mailing list