[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

Konrad Wilhelm Kleine via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 26 10:17:20 PDT 2020


kwk added inline comments.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-replace-disallow-copy-and-assign-macro.rst:31
+* Notice that the migration example above leaves the ``private`` access
+  specification untouched. This opens room for improvement, yes I know.
+
----------------
Eugene.Zelenko wrote:
> kwk wrote:
> > Eugene.Zelenko wrote:
> > > Please refer to //modernize-use-equals-delete// instead of second statement.
> > `modernize-use-equals-delete` doesn't help because it also does not remove the `private` access. Why refer to it?
> It complaines about deleted stuff in private section.
Agreed, that makes sense. Sorry for not getting that right away. Afterall I did write about that above :)

> Yes modernize-use-equals-delete does, this but it only notifies about it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80531/new/

https://reviews.llvm.org/D80531





More information about the cfe-commits mailing list