[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert added a comment.

I'm generally fine with this, don't wait for my approval.



================
Comment at: clang/test/OpenMP/amdgcn_device_function_call.cpp:27
+  }
+}
----------------
Not for this patch:
FWIW, we will need to make math functions work inside target regions. The way aomp does it is afaik different from the way we do it. We can however adopt our way for this target though. Feel free to ping me on this later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79754/new/

https://reviews.llvm.org/D79754