[PATCH] D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses

Ronald Wampler via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 26 09:11:40 PDT 2020


rdwampler added inline comments.


================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:1965
   // handle [[likely]] / [[unlikely]]
-  if (FormatTok->is(tok::l_square))
+  if (FormatTok->is(tok::l_square) && tryToParseSimpleAttribute())
     parseSquare();
----------------
>From the peanut gallery, would checking `TT_AttributeSquare` here work (that should handle ambiguities around ObjC method calls)?  


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80547/new/

https://reviews.llvm.org/D80547





More information about the cfe-commits mailing list