[PATCH] D80547: [clang-format] Fix an ObjC regression introduced with new [[likely]][[unlikely]] support in if/else clauses

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue May 26 08:06:18 PDT 2020


aaron.ballman added a comment.

In D80547#2054763 <https://reviews.llvm.org/D80547#2054763>, @MyDeveloperDay wrote:

> Handle more complex nested ObjC calls
>  Rename function to tryParseSimpleAttributes (not supporting full capability as yet)
>  Use RAII object to reset the TokenPosition
>  utilize the fact that Objective calls shouldn't end with "]]" I think... this should allow Attributes at least of the form `[[identifier::identifier]]`
>  I feel if this isn't a good enough perhaps we also check for the `;` after the second `]`


I'm not an ObjC expert, but I am pretty sure you can do something like: `[[foo bar] baz: i[0]];` and `[[foo bar] baz: i[0]][1];`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80547/new/

https://reviews.llvm.org/D80547





More information about the cfe-commits mailing list