[PATCH] D79711: [ARM] Add poly64_t on AArch32.

Tue May 26 07:00:57 PDT 2020

labrinea added a comment.

> Should poly128_t be available on AArch32 too? I don't see anything in the ACLE version you linked restricting it to AArch64 only, and the intrinsics reference has a number of intrinsics available for both ISAs using it.

It should but it is not that simple. The reason it is not available is that __int128_t is not supported in AArch32. I think that is future work, since this patch unblocks the bfloat reinterpret_cast patch, which btw is annotated with TODO comments regarding the poly128_t type for AArch32.

================
Comment at: clang/lib/Sema/SemaType.cpp:7645

   // Signed poly is mathematically wrong, but has been baked into some ABIs by
   // now.
----------------
@ostannard according to this comment it seems there has been some divergence between AArch64 and AArch32 and now is too late to change. If the ACLE doesn't say so, maybe it should.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79711/new/

https://reviews.llvm.org/D79711