[PATCH] D79961: [PGO] Fix computation of fuction Hash
Hans Wennborg via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue May 26 01:35:13 PDT 2020
hans added a comment.
In D79961#2053806 <https://reviews.llvm.org/D79961#2053806>, @serge-sans-paille wrote:
> Bump the version number to be compatible with existing profdata, in a similar fashion to v1/v2 transition.
Did you forget to include some files? I don't see the bump anywhere.
================
Comment at: clang/lib/CodeGen/CodeGenPGO.cpp:754
+ if (HashVersion == PGO_HASH_V1) {
+ MD5.update(Working);
+ } else {
----------------
Maybe explicitly show the conversion to array of uint8_t here, to make it more clear what's going on.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79961/new/
https://reviews.llvm.org/D79961
More information about the cfe-commits
mailing list