[clang] 3a2df3b - [Clang][test] fix tests when using external assembler.
Yuanfang Chen via cfe-commits
cfe-commits at lists.llvm.org
Mon May 25 16:49:10 PDT 2020
Author: Yuanfang Chen
Date: 2020-05-25T16:47:50-07:00
New Revision: 3a2df3bad07f7e5fc22538ad782e08ee55f29e41
URL: https://github.com/llvm/llvm-project/commit/3a2df3bad07f7e5fc22538ad782e08ee55f29e41
DIFF: https://github.com/llvm/llvm-project/commit/3a2df3bad07f7e5fc22538ad782e08ee55f29e41.diff
LOG: [Clang][test] fix tests when using external assembler.
Summary:
The test assume using integraed-as, so make it explicit.
Reviewered by: aganea
Differential Revision: https://reviews.llvm.org/D80454
Added:
Modified:
clang/test/Driver/cc1-spawnprocess.c
Removed:
################################################################################
diff --git a/clang/test/Driver/cc1-spawnprocess.c b/clang/test/Driver/cc1-spawnprocess.c
index 8af8cc4c0555..36df7067487c 100644
--- a/clang/test/Driver/cc1-spawnprocess.c
+++ b/clang/test/Driver/cc1-spawnprocess.c
@@ -1,18 +1,23 @@
-// RUN: %clang -fintegrated-cc1 -c -### %s 2>&1 | FileCheck %s --check-prefix=YES
+// If a toolchain uses an external assembler, the test would fail because using
+// an external assember would increase job counts. Most toolchains in tree
+// use integrated assembler, but we still support external assembler.
+// So -fintegrated-as is specified explicitly when applicable.
+
+// RUN: %clang -fintegrated-cc1 -fintegrated-as -c -### %s 2>&1 | FileCheck %s --check-prefix=YES
// RUN: %clang -fno-integrated-cc1 -c -### %s 2>&1 | FileCheck %s --check-prefix=NO
// RUN: %clang -fintegrated-cc1 -fno-integrated-cc1 -c -### %s 2>&1 \
// RUN: | FileCheck %s --check-prefix=NO
-// RUN: %clang -fno-integrated-cc1 -fintegrated-cc1 -c -### %s 2>&1 \
+// RUN: %clang -fno-integrated-cc1 -fintegrated-cc1 -fintegrated-as -c -### %s 2>&1 \
// RUN: | FileCheck %s --check-prefix=YES
-// RUN: %clang_cl -fintegrated-cc1 -c -### -- %s 2>&1 \
+// RUN: %clang_cl -fintegrated-cc1 -fintegrated-as -c -### -- %s 2>&1 \
// RUN: | FileCheck %s --check-prefix=YES
// RUN: %clang_cl -fno-integrated-cc1 -c -### -- %s 2>&1 \
// RUN: | FileCheck %s --check-prefix=NO
// RUN: env CCC_OVERRIDE_OPTIONS=+-fintegrated-cc1 \
-// RUN: %clang -fintegrated-cc1 -c -### %s 2>&1 \
+// RUN: %clang -fintegrated-cc1 -fintegrated-as -c -### %s 2>&1 \
// RUN: | FileCheck %s --check-prefix=YES
// RUN: env CCC_OVERRIDE_OPTIONS=+-fno-integrated-cc1 \
// RUN: %clang -fintegrated-cc1 -c -### %s 2>&1 \
@@ -24,7 +29,7 @@
// The following tests ensure that only one integrated-cc1 is executed.
// Only one TU, one job, thus integrated-cc1 is enabled.
-// RUN: %clang -fintegrated-cc1 -c %s -### 2>&1 | FileCheck %s --check-prefix=YES
+// RUN: %clang -fintegrated-cc1 -fintegrated-as -c %s -### 2>&1 | FileCheck %s --check-prefix=YES
// Only one TU, but we're linking, two jobs, thus integrated-cc1 is disabled.
// RUN: %clang -fintegrated-cc1 %s -### 2>&1 | FileCheck %s --check-prefix=NO
More information about the cfe-commits
mailing list