[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

Mon May 25 13:56:13 PDT 2020

lei added inline comments.

================
Comment at: clang/lib/Basic/Targets/PPC.cpp:339

   if (!(ArchDefs & ArchDefinePwr9) && (ArchDefs & ArchDefinePpcgr) &&
       llvm::find(FeaturesVec, "+float128") != FeaturesVec.end()) {
----------------
NeHuang wrote:
> I think we also need to check for `ArchDefinePwr10` and `ArchDefineFuture` based on the comment  "// We have __float128 on PPC but not power 9 and above."
> 
> `!(ArchDefs & ArchDefinePwr9)` -> `!(ArchDefs & (ArchDefinePwr9 | ArchDefinePwr10 | ArchDefineFuture))`
I would think this would be redundant since `-mcpu=pwr10` also defines `ArchDefinePwr9` ...

================
Comment at: llvm/lib/Target/PowerPC/PPC.td:211
+                                     "true",
+                                     "Enable instructions added in ISA 3.1.">;
 def FeatureP9Altivec : SubtargetFeature<"power9-altivec", "HasP9Altivec", "true",
----------------
steven.zhang wrote:
> Nit: no ending dot.
That's needed to indicate the end of the sentence.  Similar to line 208.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80020/new/

https://reviews.llvm.org/D80020