[PATCH] D80296: [clangd] Don't traverse the AST within uninteresting files during indexing

[Adam Czachorowski via Phabricator via cfe-commits]

adamcz added a comment.

Correct me if I'm wrong, but this might lead to a file never being updated in the index, even after edit, right?
Let's say you have file a.cpp that includes a.h. a.h has
namespace foo {

  #define EXPAND(foo) whatever
  #include "b.h"

}
all nodes from b.h will be inside the namespace node in a.h. If a.h did not change, b.h will never be indexed.

It's a corner case, of course, so may the speed gain is worth the cost, but don't we have inline #includes like this even in clang codebase?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80296/new/

https://reviews.llvm.org/D80296