[PATCH] D80514: [clang-tidy] modernize-use-trailing-return-type support for C++20 concepts and decltype

[Bernhard Manfred Gruber via Phabricator via cfe-commits]

bernhardmgruber marked 3 inline comments as done.
bernhardmgruber added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:285-302
+    SourceLocation End =
+        expandIfMacroId(ReturnLoc.getSourceRange().getEnd(), SM);
+    SourceLocation BeginNameF = expandIfMacroId(F.getLocation(), SM);
+
+    // Extend the ReturnTypeRange until the last token before the function
+    // name.
+    std::pair<FileID, unsigned> Loc = SM.getDecomposedLoc(End);
----------------
Is there an easier way to get the token previous to the function name?


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-use-trailing-return-type.rst:22
+  virtual float f3() const && = delete;    virtual auto f3() const && -> float = delete;
+======================================== ===============================================
 
----------------
I tried 2 online rst editors and they failed to format the code blocks inside the tables. Will this work with the clang documentation?


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-trailing-return-type.cpp:550
+
+#if __cplusplus > 201703L /* C++2a and later */
+
----------------
How do you want to handle these tests which require C++20? I have seen other checks use a separate file for tests which require a different language version.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80514/new/

https://reviews.llvm.org/D80514