[PATCH] D80472: [clangd] Add access specifier information to hover contents

Daniel Martín via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun May 24 14:24:04 PDT 2020


danielmartin updated this revision to Diff 265942.
danielmartin added a comment.

Move clang::getAccess to Specifiers.h and refactor logic in clang-doc
to use that function instead of its own.

Also changes where "public", "private" etc. is shown in the hover
contents. Now it's shown at the bottom.

Strengthens an existing unit test to also check for access specifiers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80472/new/

https://reviews.llvm.org/D80472

Files:
  clang-tools-extra/clang-doc/Generators.cpp
  clang-tools-extra/clang-doc/Generators.h
  clang-tools-extra/clang-doc/HTMLGenerator.cpp
  clang-tools-extra/clang-doc/MDGenerator.cpp
  clang-tools-extra/clangd/Hover.cpp
  clang-tools-extra/clangd/Hover.h
  clang-tools-extra/clangd/unittests/HoverTests.cpp
  clang/include/clang/Basic/Specifiers.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D80472.265942.patch
Type: text/x-patch
Size: 11384 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200524/2dd79370/attachment-0001.bin>


More information about the cfe-commits mailing list