[PATCH] D80237: [hip] Ensure pointer in struct argument has proper `addrspacecast`.

Fri May 22 20:53:32 PDT 2020

rjmccall added a comment.

In D80237#2051909 <https://reviews.llvm.org/D80237#2051909>, @hliao wrote:

> In D80237#2051887 <https://reviews.llvm.org/D80237#2051887>, @rjmccall wrote:
>
> > `addrspacecast` might be a real conversion.  I feel like this is really going well beyond what argument coercion should be expected to do, and we need to step back and re-evaluate how we're doing this.
>
>
> `addrspacecast` *must* be a no-op in terms of argument coercion.

So what does this mean exactly?  If the ABI lowering uses argument coercion in a way that changes address spaces, it must ensure that the representations are different?  So it's always *legal* to just do a memcpy here, we're just trying really hard to not do so.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80237/new/

https://reviews.llvm.org/D80237