[PATCH] D80417: Fix Darwin 'constinit thread_local' variables.
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri May 22 19:18:16 PDT 2020
rjmccall added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4145
+ // referenced directly, without calling the thread-wrapper, so the linkage
+ // must not be changed.
+ //
----------------
Is this a good idea? It seems to be making `constinit` part of the interface of a declaration, when it seems like it should strictly part of the implementation.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D80417/new/
https://reviews.llvm.org/D80417
More information about the cfe-commits
mailing list