[PATCH] D74447: [Clang] After integrated-cc1, ignore -disable-free when there are more than one job in the queue

Yuanfang Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 22 17:10:07 PDT 2020


ychen added a comment.

In D74447#1872211 <https://reviews.llvm.org/D74447#1872211>, @thakis wrote:

> I'd think that everyone debugging clang always passes a single TU to it, so I'm not sure debuggability does much here :)
>
> The `-disable-free` code has never been used in normal compilations, so we didn't have to worry about this path. This patch here brings us to 3 modes (in-process cc1 with and without disable-free, out-of-process cc1). My suggestion keeps us to two modes (in-process cc1, out-of-process cc1).


What is the downside of 3 modes except maintaining one more mode in the future?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74447/new/

https://reviews.llvm.org/D74447





More information about the cfe-commits mailing list