[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 22 16:38:17 PDT 2020


lebedev.ri resigned from this revision.
lebedev.ri added a comment.

In D80344#2051697 <https://reviews.llvm.org/D80344#2051697>, @tentzen wrote:

> In D80344#2051127 <https://reviews.llvm.org/D80344#2051127>, @lebedev.ri wrote:
>
> > This should likely be at least 3 patches: llvm middle-end, llvm codegen, clang.
> >  Langref changes missing for new intrinsics.
> >  Please post all patches with full context (`-U99999`)
>
>
> I was thinking to update docs/ExceptionHandling.rst after this patch is accepted.  Do you think this types of intrinsic should be described in Langref?
>  thanks,


It may be helpful (even for the reviewers) to first specify their behavior,
instead of writing that after-the-fact "backwardly" based on the implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80344/new/

https://reviews.llvm.org/D80344





More information about the cfe-commits mailing list