[PATCH] D76510: [analyzer] Change the default output type to PD_TEXT_MINIMAL in the frontend, error if an output loc is missing for PathDiagConsumers that need it

[Valeriy Savchenko via Phabricator via cfe-commits]

vsavchenko added a comment.

Hi @Szelethus , it looks like I am a bearer of bad news again :(
This patch seems to crash `scan-build` on pretty much every project that I tested.

One way to reproduce:

  git clone https://github.com/postgres/postgres.git
  cd postgres/
  scan-build -plist-html -o ./out ./configure 

Output:

  scan-build: Using '/Users/vsavchenko/source/llvm-project/build/Release/bin/clang-11' for static analysis
  checking build system type... x86_64-apple-darwin19.4.0
  checking host system type... x86_64-apple-darwin19.4.0
  checking which template to use... darwin
  checking whether NLS is wanted... no
  checking for default port number... 5432
  checking for block size... 8kB
  checking for segment size... 1GB
  checking for WAL block size... 8kB
  checking whether the C compiler works... no
  configure: error: in `/Users/vsavchenko/source/postgres':
  configure: error: C compiler cannot create executables
  See `config.log' for more details
  scan-build: Analysis run complete.
  scan-build: Analysis results (plist files) deposited in '/Users/vsavchenko/source/postgres/out/2020-05-22-194935-27687-1'
  scan-build: Removing directory '/Users/vsavchenko/source/postgres/out/2020-05-22-194935-27687-1' because it contains no reports.
  scan-build: No bugs found.

config.log will contain something similar to this:

  configure:3987: checking whether the C compiler works
  configure:4009: /Users/vsavchenko/source/llvm-project/build/Release/bin/../libexec/ccc-analyzer    conftest.c  >&5
  error: analyzer output type 'html' requires an output directory to be specified with -o </path/to/output_directory>
  1 error generated.
  Use of uninitialized value $HtmlDir in concatenation (.) or string at /Users/vsavchenko/source/llvm-project/build/Release/bin/../libexec/ccc-analyzer line 149, <$fh> line 2.
  mkdir /failures: Read-only file system at /Users/vsavchenko/source/llvm-project/build/Release/bin/../libexec/ccc-analyzer line 150.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76510/new/

https://reviews.llvm.org/D76510