[clang] a5b2503 - [analyzer] SATestBuild.py: Fix hang when one of the tasks fails

Valeriy Savchenko via cfe-commits cfe-commits at lists.llvm.org
Fri May 22 09:15:17 PDT 2020


Author: Valeriy Savchenko
Date: 2020-05-22T19:15:00+03:00
New Revision: a5b2503a8ab4fb21345fa9e2316530cdfaec1a60

URL: https://github.com/llvm/llvm-project/commit/a5b2503a8ab4fb21345fa9e2316530cdfaec1a60
DIFF: https://github.com/llvm/llvm-project/commit/a5b2503a8ab4fb21345fa9e2316530cdfaec1a60.diff

LOG: [analyzer] SATestBuild.py: Fix hang when one of the tasks fails

Summary:
Tasks can crash with many different exceptions including SystemExit.
Bare except still causes a warning, so let's use BaseException instead.

Differential Revision: https://reviews.llvm.org/D80443

Added: 
    

Modified: 
    clang/utils/analyzer/SATestBuild.py

Removed: 
    


################################################################################
diff  --git a/clang/utils/analyzer/SATestBuild.py b/clang/utils/analyzer/SATestBuild.py
index 39fa7ece4362..e2fe6a95138b 100755
--- a/clang/utils/analyzer/SATestBuild.py
+++ b/clang/utils/analyzer/SATestBuild.py
@@ -633,7 +633,7 @@ def run(self):
 
                 self.tasks_queue.task_done()
 
-            except CalledProcessError:
+            except BaseException:
                 self.failure_flag.set()
                 raise
 


        


More information about the cfe-commits mailing list