[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

Simon Pilgrim via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 22 08:34:11 PDT 2020


RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

In D80251#2049975 <https://reviews.llvm.org/D80251#2049975>, @craig.topper wrote:

> In D80251#2049418 <https://reviews.llvm.org/D80251#2049418>, @RKSimon wrote:
>
> > Can we add -Wsign-conversion checks to the tests? That was mentioned on PR45931
>
>
> I can. Will that do anything other than show that my test_* functions were updated to match the new type?


not much other than check for regressions again tbh.

otherwise, lgtm


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80251/new/

https://reviews.llvm.org/D80251





More information about the cfe-commits mailing list