[PATCH] D80415: [AIX] Add '-bcdtors:all:0:s' to linker to gather static init functions

Zarko Todorovski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 22 08:34:04 PDT 2020


ZarkoCA added inline comments.


================
Comment at: clang/test/Driver/aix-ld.cpp:1
+// Check powerpc-ibm-aix7.1.0.0, 32-bit. 'bcdtors' and Arguemnt order.
+// // RUN: %clang++ -no-canonical-prefixes %s -### -o %t.o 2>&1 \
----------------
s/Arguemnt/Argument/


================
Comment at: clang/test/Driver/aix-ld.cpp:7
+// // RUN:   | FileCheck --check-prefix=CHECK-LD32-ARG-ORDER %s
+// // CHECK-LD32-ARG-ORDER-NOT: warning:
+// // CHECK-LD32-ARG-ORDER: {{.*}}clang++" "-cc1" "-triple" "powerpc-ibm-aix7.1.0.0"
----------------
Add a line between the run steps and check, and can you align things vertically. 

Eg. 

```
CHECK-LD32-ARG-ORDER-NOT: warning:
CHECK-LD32-ARG-ORDER:     {{.*}}clang++" "-cc1" "-triple" "powerpc-ibm-aix7.1.0.0"
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80415/new/

https://reviews.llvm.org/D80415





More information about the cfe-commits mailing list