[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC option -EHa)

[Aaron Smith via Phabricator via cfe-commits]

asmith added inline comments.


================
Comment at: clang/lib/CodeGen/CGDecl.cpp:2003
 
+    // <tentzen>: Under -EHa, Invoke llvm.eha.scope.begin() right after
+    //      Ctor is emitted and EHStack.pushCleanup
----------------
Nit - remove name


================
Comment at: clang/lib/CodeGen/CGException.cpp:603
+
+      //  For IsEHa catch(...) must handle HW exception
+      //  Adjective = HT_IsStdDotDot (0x40), only catch C++ exceptions
----------------
nit - extra space after //


================
Comment at: clang/lib/CodeGen/CGException.cpp:1677
+      }
+    } // end of for
+  }
----------------
nit -- comment about closing brace


================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:600
 
+  if (LangOpts.EHAsynch) {
+    getModule().addModuleFlag(llvm::Module::Warning, "eh-asynch", 1);
----------------
nit - braces around single statement


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80344/new/

https://reviews.llvm.org/D80344