[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Francois Ferrand via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri May 22 04:45:18 PDT 2020


Typz added a comment.

In D50078#2050623 <https://reviews.llvm.org/D50078#2050623>, @MyDeveloperDay wrote:

> I get the point about Opt In, and if we are going to add an option it needs to go in ASAP otherwise too many people will then start complaining it was on by default before.
>
> To be honest I think the question is do we consider this a bug or a feature, because we DO NOT provide Opt In on bug fixes (and there is no Opt Out).
>
> If its a bug, there is no need for us to not have this on by default, its better to drive the improvement than 10,000's of .clang-format files needing to be updated just to get reasonable behavior.


I certainly a bit biased, but I think it is more a bug: it should have been there from the start :-)

And I also think it should be on by default instead of modifying many .clang-format files. So IMHO if we add an option, it should be opt-out.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50078/new/

https://reviews.llvm.org/D50078





More information about the cfe-commits mailing list