[PATCH] D80423: [analyzer] SATestBuild.py: Refactor and add type annotations

[Artem Dergachev via Phabricator via cfe-commits]

NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.

Nice!

I guess next time it'd be easier to review if you split up style changes from structural changes.



================
Comment at: clang/utils/analyzer/SATestBuild.py:276
 
-    AllCheckers = Checkers
-    if 'SA_ADDITIONAL_CHECKERS' in os.environ:
-        AllCheckers = AllCheckers + ',' + os.environ['SA_ADDITIONAL_CHECKERS']
+if TYPE_CHECKING:
+    ProjectQueue = Queue[ProjectInfo]  # this is only processed by mypy
----------------
What's this idiom? Like, can you explain why do we have to do this?


================
Comment at: clang/utils/analyzer/SATestBuild.py:284
+    """
+    A component all of the project testing.
+    """
----------------
Something's missing in this sentence.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80423/new/

https://reviews.llvm.org/D80423