[PATCH] D80126: Add documentation URL records to the .dia format and expose them via libclang

[Owen Voorhees via Phabricator via cfe-commits]

owenv marked an inline comment as done.
owenv added a comment.

@jkorous I'd like to add support for urls in clang-emitted diagnostics too, but I can't really commit to a timeframe for getting that done atm. I'm hoping to have some time to work on it in the next few weeks.



================
Comment at: clang/lib/Frontend/SerializedDiagnosticReader.cpp:323
+      // A documentation URL has an ID and path size.
+      if (Record.size() != 2)
+        return SDError::MalformedDiagnosticRecord;
----------------
jkorous wrote:
> I am just wondering what happens with the ID. Shouldn't we pass it too?
I think the ID should be `Record[0]` in the call t visitDocumentationURLRecord below. I based this on the handling of category records.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80126/new/

https://reviews.llvm.org/D80126