[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

Thu May 21 10:48:15 PDT 2020

hubert.reinterpretcast added a comment.

In D80300#2049181 <https://reviews.llvm.org/D80300#2049181>, @joerg wrote:

> It doesn't seem to work well with the cross-compiling support in the driver as clearly shown by the amount of tests that need patching.

I don't see the test changes as reflecting that at all. If a user was able to use `--dyld-prefix` with the value being set as the default, then it just works. That would depend on the user's environment, which is something that the packager/builder of Clang might know something about or have control over.

> I would suggest going a slightly different route and use default values iff no "-target" or "target-command" mechanism is active.

I'm not sure I see enough of a difference between the newly added customization points and `DEFAULT_SYSROOT`. The latter does not act conditionally in the manner proposed above.

> Might need a way to temporarily disable unused flag warnings, but that way would be pretty much toolchain independent?

Can you elaborate on this? I'm not sure I caught the line of reasoning that led to this comment.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80300/new/

https://reviews.llvm.org/D80300