[PATCH] D80317: [SYCL] Prohibit arithmetic operations for incompatible pointers

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

Please add a C test case just using the address_space attribute.



================
Comment at: clang/include/clang/AST/Type.h:1069
+  /// qualifiers.
+  bool isAddressSpaceOverlapping(const QualType &T) const {
+    Qualifiers Q = getQualifiers();
----------------
It's idiomatic to take `QualType` by value rather than `const &`.

Can you rewrite the `PointerType` method to delegate to this?  Assuming it isn't completely dead, that is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80317/new/

https://reviews.llvm.org/D80317