[PATCH] D80323: [SVE] Eliminate calls to default-false VectorType::get() from Clang

Francesco Petrogalli via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 21 10:15:35 PDT 2020


fpetrogalli added a comment.

In D80323#2048457 <https://reviews.llvm.org/D80323#2048457>, @rjmccall wrote:

> I'm sympathetic to wanting to get rid of the boolean flag, but this is a really invasive change for pretty minimal benefit.  Why not leave `VectorType::get` as meaning a non-scalable vector type and come up with a different method name to get a scalable vector?


Sorry @rjmccall , I saw your comments only after approving this patch. I didn't mean to enforce my views over yours.

@ctetreau , please make sure you address @rjmccall comment before submitting.

Kind regards,

Francesco


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80323/new/

https://reviews.llvm.org/D80323





More information about the cfe-commits mailing list