[PATCH] D80362: [WebAssembly] Warn on exception spec only when Wasm EH is used

Derek Schuff via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu May 21 09:09:11 PDT 2020


dschuff accepted this revision.
dschuff added a comment.
This revision is now accepted and ready to land.

otherwise LGTM



================
Comment at: clang/docs/DiagnosticsReference.rst:14018
++-----------------------------------------------------------------------------------------------------------------------------------+
+|:warning:`warning:` |nbsp| :diagtext:`dynamic exception specifications with types are currently ignored in wasm exception handling`|
++-----------------------------------------------------------------------------------------------------------------------------------+
----------------
I think it's not actually necessary to change the text of the warning. Since the warning is about an exception handling language feature, I think adding "exception handling" on the end doesn't make it any more clear and sounds a little redundant to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80362/new/

https://reviews.llvm.org/D80362





More information about the cfe-commits mailing list