[PATCH] D78099: [analyzer][RetainCount] Tie diagnostics to osx.cocoa.RetainCount rather then RetainCountBase, for the most part

[Gabor Marton via Phabricator via cfe-commits]

martong requested changes to this revision.
martong added a comment.
This revision now requires changes to proceed.

Found a small mistake that should be corrected, then will be good to me.



================
Comment at: clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp:15
 #include "RetainCountChecker.h"
+#include "clang/StaticAnalyzer/Core/Checker.h"
 #include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
----------------
Why adding this extra header? Don't blame clangd :D


================
Comment at: clang/test/Analysis/test-separate-retaincount.cpp:5
 //
-// RUN: %clang_analyze_cc1 -std=c++14 -DNO_OS_OBJECT -verify %s \
+// RUN: %clang_analyze_cc1 -std=c++14 -verify=no-retain-count %s \
 // RUN:   -analyzer-checker=core,osx \
----------------
This is mixed up with line 1, this line should be `no-os-object`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78099/new/

https://reviews.llvm.org/D78099