[PATCH] D80300: [Driver] Add DEFAULT_DYLD_PREFIX and DEFAULT_RPATH to complement DEFAULT_SYSROOT

Thu May 21 03:45:28 PDT 2020

nemanjai accepted this revision.
nemanjai added subscribers: tstellar, brad, craig.topper, joerg.
nemanjai added a comment.
This revision is now accepted and ready to land.

Thank you for sorting this out. I think it is quite useful to be able to configure the compiler to use complete non-standard toolchains that include a dynamic linker.
Could you please ensure that the commit message describes that the `--dyld-prefix` option is added to test cases since they check for the dynamic linker and would fail on builds that specify a default prefix?
Also, you might want to add someone from some of the other targets/platforms as a reviewer to ensure there is no objections (perhaps @craig.topper, @tstellar, @brad or @joerg).

LGTM but maybe give others a few days to have a look.

================
Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:452
       CmdArgs.push_back("-dynamic-linker");
-      CmdArgs.push_back(Args.MakeArgString(Loader));
+      CmdArgs.push_back(Args.MakeArgString(Twine(D.DyldPrefix) +
+                                           ToolChain.getDynamicLinker(Args)));
----------------
Is this just an orthogonal NFC change? If so, can you please commit it separately in an NFC commit?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80300/new/

https://reviews.llvm.org/D80300