[PATCH] D75791: [clang-format] Added new option IndentExternBlock

MyDeveloperDay via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 20 14:18:41 PDT 2020


MyDeveloperDay added inline comments.


================
Comment at: clang/include/clang/Format/Format.h:1531
+    /// \endcode
+    ///
+    /// \code
----------------
@MarcusJohnson91 I had to make a couple of minor changes before committing 

1) it needed rebasing (because of changes from this morning)
2) these \code statements need to be indented by 3 spaces otherwise it can't see the beginning and end of the code segment and would have failed the doc build
3) There were a couple of extra blank lines in the release notes (I actually think that was my mistake this morning) but it failed the rest lint check that I use

The tests ran ok especially our new one, so I don't think this has broken the default styles, we'll see if anyone else complains

Thank you for the patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75791/new/

https://reviews.llvm.org/D75791





More information about the cfe-commits mailing list