[PATCH] D80289: [Driver][X86] Support branch align options with LTO

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 20 08:11:00 PDT 2020


MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:501
+  // Handle options for branch align
+  if (Args.hasArg(options::OPT_mbranches_within_32B_boundaries)) {
+    CmdArgs.push_back("-plugin-opt=-x86-branches-within-32B-boundaries");
----------------
The large chunk of code duplicates Clang.cpp:addX86AlignBranchArgs.

Can you refactor addX86AlignBranchArgs to be reused here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80289/new/

https://reviews.llvm.org/D80289





More information about the cfe-commits mailing list