[PATCH] D80293: [clangd] Run PreambleThread in async mode behind a flag

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed May 20 07:35:25 PDT 2020


kadircet marked an inline comment as done.
kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:248
+      ReqCV.wait(Lock, [this] {
+        return !NextReq || NextReq->WantDiags != WantDiagnostics::Yes;
+      });
----------------
This is mostly to make sure tests do not regress, I am not sure if we have any real world uses of it though.

I would love to just drop this and change tests instead. WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80293/new/

https://reviews.llvm.org/D80293





More information about the cfe-commits mailing list